-
-
Notifications
You must be signed in to change notification settings - Fork 37
Feature/shortcuts #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/shortcuts #153
Conversation
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments. I'd use all upper case for the shortcuts and maybe we should figure out how to do this without using global shortcuts.
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get rid of the code in index.js that is commented out and we're good to go.
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
This PR implements keyboard shortcuts.
Attention has been made to disable them based on context and wether or not the user is performing operations int he REPL.
The shortcuts are also reflected in the tooltips dynamically replacing
Cmd+
withCtrl+
wether the user is on Mac OS or Windows/LinuxThese shortcuts are thought to have direct single Meta Key action for the most immediate ones
Run
->Meta+r
Stop
->Meta+h
(h
as inhalt
)Save
->Meta+s
Holding
Alt
(Option
) will also enableRun selected
->Meta+Alt+r
(also works holdingAlt
when clicking the Run button)Will only run the code highlighted by the user.
If they accidentally only select whitespace (double-click on an empty line will do) it will run the whole script.
These other shortcuts require the use of
Shift
and are not of immediate needConnect
->Meta+Shift+C
Disconnect
->Meta+Shift+D
Reset
->Meta+Shift+R
Clear Terminal
->Meta+k
Because of
Reset
, the default Electron shortcut for "Application Reload" is disabled, but the menu item still present and actionable underView
>Reload
The default Electron shortcut for "Toggle Developer Tools" is disabled, but the menu item still present and actionable under
View
>Toggle Developer Tools
Connect
andDisconnect
work also in the File Manager view, while other shortcuts are disabled.