-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
docs(IoC): modified description about example
Co-Authored-By: kambleaa007 <[email protected]>
docs (IoC): Update docs/content/guide/di.ngdoc
Update docs/content/guide/di.ngdoc
docs(docs): Update docs/content/guide/di.ngdoc
Couple of typos fixed: - indentation - start periodic checking - missing brace
Couple of typos fixed: - indentation - start periodic checking - missing brace
Co-Authored-By: kambleaa007 <[email protected]>
Update validators.js
chore(github): update PR template to highlight LTS mode
docs(di): update docs content
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
This again seems to include changes from #16833. Please, take a moment to read through these instructions (in case you haven't). |
AngularJS is in LTS mode
We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.
Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: