Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(di): update docs content #16852

Closed
wants to merge 15 commits into from
Closed

Conversation

kambleaa007
Copy link
Contributor

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

kambleaa007 and others added 15 commits February 16, 2019 19:28
docs(IoC): modified description about example
docs (IoC): Update docs/content/guide/di.ngdoc
Update docs/content/guide/di.ngdoc
docs(docs): Update docs/content/guide/di.ngdoc
Couple of typos fixed:
- indentation
- start periodic checking
- missing brace
Couple of typos fixed:
- indentation
- start periodic checking
- missing brace
 chore(github): update PR template to highlight LTS mode
docs(di): update docs content
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@gkalpak
Copy link
Member

gkalpak commented Mar 5, 2019

This again seems to include changes from #16833. Please, take a moment to read through these instructions (in case you haven't).

@gkalpak gkalpak closed this Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants