docs(guide/di): clarify example description #16833
Conversation
docs/content/guide/di.ngdoc
Outdated
| @@ -283,9 +283,12 @@ Here is an example of using the injector service: | |||
| // Provide the wiring information in a module | |||
| var myModule = angular.module('myModule', []); | |||
| ``` | |||
| Notice that `myModule` is independent as array is empty here. | |||
| Dependent is always need dependency object to be injected inside it. | |||
There was a problem hiding this comment.
I don't understand this sentence. Remember that the previous code snippet is defining a module so it is not helpful to refer to "objects" here.
docs/content/guide/di.ngdoc
Outdated
|
|
||
| Teach the injector how to build a `greeter` service. Notice that `greeter` is dependent on the | ||
| `$window` service. The `greeter` service is an object that contains a `greet` method. | ||
| so, injector now injects `$window` dependency inside `greeter` service. |
There was a problem hiding this comment.
I don't feel that this sentence makes sense. If anything it should appear before the previous sentence and should be something more like
Notice that
greeteris dependent on the$windowservice, which will be provided by the injector when it is instantiated.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
@petebacondarwin thanks, |
kambleaa007
changed the title
kambleaa007
changed the title
docs/content/guide/di.ngdoc
Outdated
| @@ -14,7 +14,8 @@ and providing them to other components as requested. | |||
|
|
|||
| ## Using Dependency Injection | |||
|
|
|||
| Dependency Injection is pervasive throughout AngularJS. You can use it when defining components | |||
| Dependency Injection is pervasive throughout AngularJS. | |||
| You can use it when defining components | |||
|
Hello all, |
|
@kambleaa007 what errors? You should not need access to write to the main repository. You just write to your own fork, |
Travis Giving me:- CLAs are signed, but unable to verify author consent |
|
This is because @mgol and I have made commits to this PR. You can ignore this error. |
That's great, |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
gkalpak
changed the title
|
I tweaked this a bit and merged. Thx, @kambleaa007 👍 |
docs(IoC): modified description about example
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: