docs(guide/Conceptual Overview): describe your change...

[stevanlauriault]

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Other information:

No definition found for Table yahoo.finance.xchange

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[stevanlauriault]

I signed it.

On Oct 26, 2016, at 9:24 AM, googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the company's name.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #15317 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AHHZ8_xCtvFj3cO-e759Vgz0MulZezHzks5q31R7gaJpZM4KhKUV.

[googlebot]

CLAs look good, thanks!

[Narretz]

I don't see this message, neither on the snapshot docs nor in the plnkr.

[gkalpak]

I see it in the plnkr. I think it might be related to temporary issue with datatables.org.
Let's wait and see if the problem persists. (But if it does, we should find an alternative - just adding a note that the example does not work is not good enough imo.)

[stevanlauriault]

Under Accessing the backend, shouldn't {{invoice.total(c) | currency:c}} in
index.html have an output?

On 26 Oct 2016 2:35 p.m., "Martin Staffa" [email protected] wrote:

I don't see this message, neither on the snapshot docs
https://code.angularjs.org/snapshot/docs/guide/concepts nor in the
plnkr.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#15317 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHHZ8wYrbSPUtKH8KsAf9PvmFyk4DM2xks5q351sgaJpZM4KhKUV
.

[Narretz]

That's right, there should be output which is blocked because the url cannot be loaded. Did you mean that originally? It helps to be specific from the start in these cases.

[Narretz]

It looks like the Yahoo Finance API is gone or at least broken: http://stackoverflow.com/questions/38355075/has-yahoo-finance-web-service-disappeared-api-changed-down-temporarily

There's also no official page from Yahoo for it, so we probably have to use a different service.

[Narretz]

Actually ... the API still works, but our jsonp doesn't work on plnkr in the snapshot / master build.
Reason:

• when the plnkr is generated from the snapshot build, it doesn't use the snapshot angular files, but the stable version (1.5.8 currently). Since we changed how the JSON_CALLBACK is replaced in the url in the snapshot, the example breaks because the url definition and the 1.5.8 implementation are not compatible.
• on the docs website, the snapshot examples don't work because jsonp requests now require the url to be whitelisted in sce

Conclusion:

• make it so that the docs for snapshot use the corresponding snapshot files in the plnkr examples.
• Additionally, wee need to add the finance api to the $sceDelegateProvider.resourceUrlWhitelist to make it snapshot compatible (to make it work both in docs app and plnkr)

                          docs  |   plnkr
1.5.8                     y     |   n
snapshot                  n     |   n
snapshot (whitelisted)    ?     |   n

[Narretz]

The fix for JSONP is here: #15336

And the issue to track the mismatch of versions with plnkr is tracked here: #15267