Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: mismatch between Angular version in embedded examples and plnkr examples on master #15267

Closed
Narretz opened this issue Oct 14, 2016 · 1 comment · Fixed by #15269
Closed

docs: mismatch between Angular version in embedded examples and plnkr examples on master #15267

Narretz opened this issue Oct 14, 2016 · 1 comment · Fixed by #15269
Labels
frequency: high severity: confusing type: docs
Milestone
Backlog - won't fix

Comments

@Narretz
Copy link
Contributor

Narretz commented Oct 14, 2016 •
edited
Loading

See http://stackoverflow.com/questions/40043549/ng-switch-when-separator-not-working-in-angularjs/40044632#40044632

Maybe this should be fixed in dgeni-packages/examples.

The plnkr opener requests the manifest.json, which contains the files that should appear in the plnkr. And the files are generated by dgeni based on the deployments. So maybe we need an extra plnkr deployment?
@Narretz Narretz changed the title docs: mismath between Angular version in embedded examples and plnkr examples docs: mismatch between Angular version in embedded examples and plnkr examples Oct 14, 2016
@Narretz Narretz changed the title docs: mismatch between Angular version in embedded examples and plnkr examples docs: mismatch between Angular version in embedded examples and plnkr examples on master Oct 14, 2016
Narretz added a commit to Narretz/angular.js that referenced this issue Oct 14, 2016
@Narretz
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
94ed5b4 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Fixes angular#15267
Narretz added a commit to Narretz/angular.js that referenced this issue Oct 14, 2016
@Narretz
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
5df6a4e 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Fixes angular#15267
@Narretz Narretz mentioned this issue Oct 14, 2016
Merged
1 task
Narretz added a commit that referenced this issue Oct 17, 2016
@Narretz
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
db02008 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes #15267
PR (#15269)
Narretz added a commit that referenced this issue Oct 17, 2016
@Narretz
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
0a2b723 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes #15267
PR (#15269)
@Narretz
Copy link
Contributor Author

Narretz commented Oct 18, 2016

Fix was wrong, reopening

@Narretz Narretz reopened this Oct 18, 2016
@gkalpak gkalpak modified the milestones: Backlog2, Backlog Oct 18, 2016
@Narretz Narretz mentioned this issue Oct 29, 2016
Closed
3 tasks
Narretz added a commit to Narretz/angular.js that referenced this issue Nov 3, 2016
@Narretz
chore(docs-gen): create plnkr examples with the correct version
0bd2604 
Closes angular#15267
Narretz added a commit to Narretz/angular.js that referenced this issue Nov 4, 2016
@Narretz
chore(docs-gen): create plnkr examples with the correct version
a0b99f4 
Closes angular#15267
@Narretz Narretz closed this as completed in b28f1fc Nov 5, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this issue Nov 21, 2016
@Narretz @petebacondarwin
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
d2564ab 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes angular#15267
PR (angular#15269)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this issue Nov 21, 2016
@Narretz @petebacondarwin
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
34575c0 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes angular#15267
PR (angular#15269)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this issue Nov 21, 2016
@Narretz @petebacondarwin
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
2df947f 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes angular#15267
PR (angular#15269)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this issue Nov 21, 2016
@Narretz @petebacondarwin
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
de2199e 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes angular#15267
PR (angular#15269)
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this issue Nov 21, 2016
@Narretz @petebacondarwin
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
ca8322d 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes angular#15267
PR (angular#15269)
petebacondarwin pushed a commit that referenced this issue Nov 23, 2016
@Narretz @petebacondarwin
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
49de157 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes #15267
PR (#15269)
petebacondarwin pushed a commit that referenced this issue Nov 24, 2016
@Narretz @petebacondarwin
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
fddc534 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes #15267
PR (#15269)
gkalpak pushed a commit that referenced this issue Nov 28, 2016
@Narretz @gkalpak
chore(docs-gen): create plnkr examples with the correct version
150a519 
- docs for the snapshot will include the snapshot files from code.angularjs.org
- docs for tagged versions will include the files from the (Google) CDN
- docs for local / untagged versions will try to include the files from the (Google) CDN, which will fail. This gives immediate feedback that something is broken.

Closes #15267
Closes #15358
ellimist pushed a commit to ellimist/angular.js that referenced this issue Mar 15, 2017
@Narretz @ellimist
chore(doc-gen, docs-app): create plnkr examples with correct Angular …
26ecd2e 
…version

When the docs are based on the snapshot, the plnkr examples must use the snapshot files
from code.angularjs.org

Closes angular#15267
PR (angular#15269)
ellimist pushed a commit to ellimist/angular.js that referenced this issue Mar 15, 2017
@Narretz @ellimist
chore(docs-gen): create plnkr examples with the correct version
155e4d9 
- docs for the snapshot will include the snapshot files from code.angularjs.org
- docs for tagged versions will include the files from the (Google) CDN
- docs for local / untagged versions will try to include the files from the (Google) CDN, which will fail. This gives immediate feedback that something is broken.

Closes angular#15267
Closes angular#15358
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frequency: high severity: confusing type: docs
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

chore(doc-gen, docs-app): create plnkr examples with correct Angular … Narretz/angular.js
2 participants
@Narretz @gkalpak