fix(tooltip): Attributes no longer evaluated in isolate scope

[joshdmiller]

The tooltip directive has been re-architected to use a new scope rather
than an isolate scope, but the templated tooltipPopup directive now has
an isolate scope to introduce a similar level of scope security. As the
isolate scope is gone, the transclusion logic has been removed. In
addition, tooltip attributes are $observed manually to assign the
necessary variables on the child scope needed by the tooltipPopup
directive.

Closes #78.

[petebacondarwin]

Nice one!

On 24 January 2013 20:42, Josh D Miller [email protected] wrote:

The tooltip directive has been re-architected to use a new scope rather
than an isolate scope, but the templated tooltipPopup directive now has
an isolate scope to introduce a similar level of scope security. As the
isolate scope is gone, the transclusion logic has been removed. In
addition, tooltip attributes are $observed manually to assign the
necessary variables on the child scope needed by the tooltipPopup
directive.

Closes #78 #78.

You can merge this Pull Request by running

git pull https://github.com/joshdmiller/bootstrap tooltip-scope

Or view, comment on, or merge it at:

#92
Commit Summary

• fix(tooltip): Attributes no longer evalued in isolate scope

File Changes

• M src/tooltip/test/tooltipSpec.js (46)
• M src/tooltip/tooltip.js (45)
• M template/tooltip/tooltip-popup.html (2)

Patch Links:

• https://github.com/angular-ui/bootstrap/pull/92.patch
• https://github.com/angular-ui/bootstrap/pull/92.diff

[pkozlowski-opensource]

@joshdmiller, great stuff, landed it as 29aed22.

Are we ready to start talking about popovers? If so let's start a thread on angular-ui!