Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Tooltip issues #78

Closed
pkozlowski-opensource opened this issue Jan 21, 2013 · 4 comments
Closed

Tooltip issues #78

pkozlowski-opensource opened this issue Jan 21, 2013 · 4 comments
Labels
type: bug
Milestone
0.1.0

Comments

@pkozlowski-opensource
Copy link
Member

Based on discussion in #72 looks like there are still issues with the tooltip:

Oops, sorry for sending you a bad version! Here's the version I meant to send:
http://plnkr.co/edit/1GiwHv
That version demonstrates there's still a problem when you give a tooltip to a link whose href is bound to a value that is initially falsey: even after the value changes to something truthy, the href attribute stays set to nothing.
@joshdmiller
Copy link
Contributor

It looks like all the attributes are being evaluated within the isolate scope. I'll look into this.

@pkozlowski-opensource
Copy link
Member Author

Report on SO, just in case, so we don't introduce regressions while fixing this bug:
http://stackoverflow.com/questions/14454283/ui-bootstrap-tooltip-doesnt-work-when-used-with-ng-repeat

@joshdmiller
Copy link
Contributor

@pkozlowski-opensource I included a test in the last PR to cover that specific case (ngRepeat), so we should be okay.

I may not have a chance to look into this until Wednesday/Thursday.

joshdmiller pushed a commit to joshdmiller/bootstrap that referenced this issue Jan 24, 2013
fix(tooltip): Attributes no longer evalued in isolate scope
74b572a 
The tooltip directive has been re-architected to use a new scope rather
than an isolate scope, but the templated tooltipPopup directive now has
an isolate scope to introduce a similar level of scope security. As the
isolate scope is gone, the transclusion logic has been removed. In
addition, tooltip attributes are $observed manually to assign the
necessary variables on the child scope needed by the tooltipPopup
directive.

Closes angular-ui#78.
@joshdmiller joshdmiller mentioned this issue Jan 24, 2013
Closed
@lanterndev lanterndev mentioned this issue Feb 9, 2013
Closed
@lanterndev
Copy link
Contributor

see #132

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

fix(tooltip): Attributes no longer evaluated in isolate scope joshdmiller/bootstrap
3 participants
@joshdmiller @lanterndev @pkozlowski-opensource