-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Heaps algorithm iterative #2505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cclauss
merged 16 commits into
TheAlgorithms:master
from
grochedix:heaps_algorithm_iterative
Sep 29, 2020
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1f99120
Merge remote-tracking branch 'upstream/master'
grochedix b5769f7
Merge remote-tracking branch 'upstream/master'
grochedix 3708397
Merge remote-tracking branch 'upstream/master'
grochedix 4cfb62f
Merge branch 'master' of https://github.com/TheAlgorithms/Python
grochedix 86b62a9
Merge remote-tracking branch 'upstream/master'
grochedix 28a56c8
Merge remote-tracking branch 'upstream/master'
grochedix fb2b5ba
Merge remote-tracking branch 'upstream/master'
grochedix d8934d5
Merge remote-tracking branch 'upstream/master'
grochedix 8a575f7
Merge remote-tracking branch 'upstream/master'
grochedix e8539c6
Merge remote-tracking branch 'upstream/master'
grochedix c638204
Merge remote-tracking branch 'upstream/master'
grochedix 87a00a0
Merge remote-tracking branch 'upstream/master'
grochedix 567112a
heap's algorithm iterative
grochedix 32b396e
doctest
grochedix df1ae96
doctest
grochedix bb9b7df
rebuild
grochedix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
""" | ||
Heap's (iterative) algorithm returns the list of all permutations possible from a list. | ||
It minimizes movement by generating each permutation from the previous one | ||
by swapping only two elements. | ||
More information: | ||
https://en.wikipedia.org/wiki/Heap%27s_algorithm. | ||
""" | ||
|
||
|
||
def heaps(arr: list) -> list: | ||
""" | ||
Pure python implementation of the iterative Heap's algorithm, | ||
returning all permutations of a list. | ||
>>> heaps([]) | ||
[()] | ||
>>> heaps([0]) | ||
[(0,)] | ||
>>> heaps([-1, 1]) | ||
[(-1, 1), (1, -1)] | ||
>>> heaps([1, 2, 3]) | ||
[(1, 2, 3), (2, 1, 3), (3, 1, 2), (1, 3, 2), (2, 3, 1), (3, 2, 1)] | ||
>>> from itertools import permutations | ||
>>> sorted(heaps([1,2,3])) == sorted(permutations([1,2,3])) | ||
True | ||
>>> all(sorted(heaps(x)) == sorted(permutations(x)) | ||
... for x in ([], [0], [-1, 1], [1, 2, 3])) | ||
True | ||
""" | ||
|
||
if len(arr) <= 1: | ||
return [tuple(arr)] | ||
|
||
res = [] | ||
|
||
def generate(n: int, arr: list): | ||
c = [0] * n | ||
res.append(tuple(arr)) | ||
|
||
i = 0 | ||
while i < n: | ||
if c[i] < i: | ||
if i % 2 == 0: | ||
arr[0], arr[i] = arr[i], arr[0] | ||
else: | ||
arr[c[i]], arr[i] = arr[i], arr[c[i]] | ||
res.append(tuple(arr)) | ||
c[i] += 1 | ||
i = 0 | ||
else: | ||
c[i] = 0 | ||
i += 1 | ||
|
||
generate(len(arr), arr) | ||
return res | ||
|
||
|
||
if __name__ == "__main__": | ||
user_input = input("Enter numbers separated by a comma:\n").strip() | ||
arr = [int(item) for item in user_input.split(",")] | ||
print(heaps(arr)) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I think we are ready to land this one.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the iterative version as well as the recursive one (#2475 ) with your suggestion.
Thanks for reviewing ! 👍
Edit: I see there is a problem with pytest but looks like you're working on it so i leave it like that for now.