Heaps algorithm iterative #2505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Sep 28, 2020
| >>> from itertools import permutations | ||
| >>> sorted(heaps([1,2,3])) == sorted(permutations([1,2,3])) | ||
| True | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """ | |
| >>> all(sorted(heaps(x)) == sorted(permutations(x)) for x in ([], [0], [-1, 1], [1, 2, 3])) | |
| True | |
| """ |
There was a problem hiding this comment.
Then I think we are ready to land this one.
There was a problem hiding this comment.
Modified the iterative version as well as the recursive one (#2475 ) with your suggestion.
Thanks for reviewing ! 👍
Edit: I see there is a problem with pytest but looks like you're working on it so i leave it like that for now.
|
Hey @grochedix, TravisCI finished with status TravisBuddy Request Identifier: 48073680-01b6-11eb-9be6-0d9634a5fbe7 |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* heap's algorithm iterative * doctest * doctest * rebuild
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* heap's algorithm iterative * doctest * doctest * rebuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Iterative Heap's algorithm.
Checklist:
Fixes: #{$ISSUE_NO}.