This repository was archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Prepare for stable 1.0 release #10
Merged
weierophinney
merged 7 commits into
zendframework:master
from
weierophinney:feature/stable-release
Sep 28, 2018
Merged
Prepare for stable 1.0 release #10
weierophinney
merged 7 commits into
zendframework:master
from
weierophinney:feature/stable-release
Sep 28, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that 1.0 is released and stable, we should no longer support pre-release versions. All tests continue to pass.
- Version documentation - Provide full usage for package
Ping @froschdesign — could you take a quick look at the docs for me, please? I think with this one done, we're only waiting on @ezimuel to finish the OAuth2 adapter before all adapters are finally stable! 🎉 |
froschdesign
suggested changes
Sep 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small changes required, otherwise good! 👍
docs/book/v1/intro.md
Outdated
@@ -0,0 +1,108 @@ | |||
# zend-expressive-authentication-basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/book/v1/intro.md
Outdated
'/path/requiring/authentication', | ||
[ | ||
Zend\Expressive\Authentication\AuthenticationMiddleware::class, | ||
HandlerRequiringAuthentication::class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an extra comment would be good: // Add your own handler here
or // Replace with your own handler
- Intro for package introduction - Configuration - Usage
- Future 7.3
- Adds dev-develop => 1.1.x-dev
- Adds 1.0.0 section - Adds entries for zendframework#10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does two things: