Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Prepare for stable 1.0 release #10

Merged

Conversation

weierophinney
Copy link
Member

This patch does two things:

  • Bumps the minimum supported zend-expressive-authentication version to 1.0. Tests continue to pass, and, when introspecting the adapter, no code changes are required.
  • Prepares the documentation for the stable release, adding full usage and configuration details.

Now that 1.0 is released and stable, we should no longer support
pre-release versions.

All tests continue to pass.
- Version documentation
- Provide full usage for package
@weierophinney
Copy link
Member Author

Ping @froschdesign — could you take a quick look at the docs for me, please? I think with this one done, we're only waiting on @ezimuel to finish the OAuth2 adapter before all adapters are finally stable! 🎉

Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small changes required, otherwise good! 👍

@@ -0,0 +1,108 @@
# zend-expressive-authentication-basic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this headline should be "Introduction", because:

  • the page is named with "Introduction"
  • the homepage already has this headline

'/path/requiring/authentication',
[
Zend\Expressive\Authentication\AuthenticationMiddleware::class,
HandlerRequiringAuthentication::class,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an extra comment would be good: // Add your own handler here or // Replace with your own handler

- Intro for package introduction
- Configuration
- Usage
- Adds dev-develop => 1.1.x-dev
- Adds 1.0.0 section
- Adds entries for zendframework#10
@weierophinney weierophinney merged commit 65f5f95 into zendframework:master Sep 28, 2018
weierophinney added a commit that referenced this pull request Sep 28, 2018
@weierophinney weierophinney deleted the feature/stable-release branch September 28, 2018 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants