This repository was archived by the owner on Jan 26, 2019. It is now read-only.
Get tests up and running #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails because TypeScript can't find the definitions for node and jest. A fix affects the production tsconfig so for now the best solution seems to be to deactivate this specific test.
These tests rely on an example project that has to be migrated to TypeScript first.
Certain es6 features like destructuring and default parameters are not supported by node 4.x.
|
This is awesome! Let me take a proper look and we'll get it merged! |
wmonk
approved these changes
May 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
./tasks/e2e-simple.shand./tasks/e2e-installs.sh../tasks/e2e-kitchensink.shstill does not work since it depends on the sample project./packages/react-scripts/fixtures/kitchensink/which is not ported to TypeScript yet.One test had to be disabled. It only tests that the dev environment still works so I think it should be expendable. The problem is the template in
./packages/react-scripts/template. It has no package.json of its own so itsnode_modulesare stored in the parent folder. Apparently autoloading thenodeandjest@types then fails, although it should work according to the TypeScript docs [1]. I only managed to get it to work by adjusting thetsconfig.jsonand setting thetypesRootto the parent'snode_modules. That change would also be part of thetsconfig.jsondeployed to the apps created with this package.b03c7a4 is just a fix so the build script also runs with node 4. If you don't want to support node 4 you can omit this commit. You may want to adjust the
.travis.ymlconfig if you want to activate Travis.I activated Travis on my fork and it is looking good so far: https://travis-ci.org/migerh/create-react-app-typescript/builds/227103514
[1] https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types