Skip to content
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Ignore test coverage for definitions files #406

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Conversation

r3nya
Copy link
Contributor

@r3nya r3nya commented Sep 27, 2018

Why?

Typical situation when ts project has extra declaration files (for json, css, some packages w/o types etc). And when you try to get coverage from your tests you will see definitions files as well (*.d.ts).
We need to ignore it.

Demo

Before

image

After

image

@r3nya
Copy link
Contributor Author

r3nya commented Sep 28, 2018

Hey @elektronik2k5 @DorianGrey!
Please take a look. 😉

Copy link
Collaborator

@DorianGrey DorianGrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minimal style issue here, apart from that, LGTM.

@wmonk wmonk merged commit 10a5957 into wmonk:master Sep 28, 2018
@r3nya r3nya deleted the patch-1 branch September 28, 2018 14:39
@wmonk
Copy link
Owner

wmonk commented Sep 28, 2018

Released in 3.1.0

@r3nya
Copy link
Contributor Author

r3nya commented Sep 28, 2018

Thanks @wmonk!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants