Skip to content

updated 4.md #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 1, 2019
Merged

updated 4.md #2834

merged 16 commits into from
Aug 1, 2019

Conversation

kolharsam
Copy link
Contributor

Added more links to installation guides and about plugins.

This is in regards to the issue #1934

Would appreciate any helping me to make continuous contributions to the documentation of the webpack and especially this document.

@kolharsam
updated 4.md
f0e5a54 
Made certain changes to the document that I thought was necessary. Added more links to installation guides and about plugins. 

This is in regards to the issue [webpack#1934](webpack#1934)
@kolharsam
Merge pull request #1 from Kolhar730/Kolhar730-patch-1
0ee76fa 
updated 4.md
EugeneHlushko
EugeneHlushko requested changes Mar 2, 2019
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a couple of suggestions and thoughts, hope it helps

@kolharsam
Copy link
Contributor Author

@EugeneHlushko I have committed the latest 4.md file upon taking into consideration all the suggestions that you had to give.

Since this is still an open issue, what more can I add to help improve it?

wizardofhogwarts
wizardofhogwarts suggested changes May 30, 2019
View reviewed changes
Copy link
Contributor

@wizardofhogwarts wizardofhogwarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this resolves a prominent issue, though not completely. @EugeneHlushko we must move forward with this.

EugeneHlushko
EugeneHlushko requested changes Jun 3, 2019
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one more request

@montogeek
Copy link
Member

@Kolhar730 Friendly ping

@netlify
Copy link

netlify bot commented Jul 17, 2019 •
edited
Loading

Preview is ready

Built with commit ba35ba1

https://deploy-preview-2834--webpackjsorg-netlify.netlify.com

@kolharsam
Copy link
Contributor Author

@Kolhar730 Friendly ping

Hi!
Do you wish to add more to the branch?

EugeneHlushko
EugeneHlushko requested changes Jul 24, 2019
View reviewed changes
@kolharsam
Copy link
Contributor Author

@EugeneHlushko I have added the yaml frontmatter as requested

EugeneHlushko
EugeneHlushko requested changes Jul 29, 2019
View reviewed changes
@kolharsam
Copy link
Contributor Author

@EugeneHlushko is it okay now?

EugeneHlushko
EugeneHlushko requested changes Jul 31, 2019
View reviewed changes
@kolharsam
Copy link
Contributor Author

@montogeek & @EugeneHlushko thanks for all the help along the way. If you don't mind, could you lead me to any other aspect of the docs that need work to be done? Will be happy to help.

@montogeek montogeek merged commit 680b7b9 into webpack:master Aug 1, 2019
@montogeek
Copy link
Member

Thanks!

@montogeek
Copy link
Member

Feel free to navigate the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko requested changes

@wizardofhogwarts wizardofhogwarts wizardofhogwarts requested changes

@montogeek montogeek montogeek approved these changes

Assignees
No one assigned
Labels
Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kolharsam @montogeek @EugeneHlushko @wizardofhogwarts