-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Rebuild Support for custom Markdown on Configuration page #2564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good already m8! would like to see the final thing asap and merge the bloody rebuild
into master 👯 👯 👯 👨🎨 👍
Me too, me too |
@EugeneHlushko Please take a look, once this is merged, we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small formatting notes, also a suggestion for mobile UX. Although if you want, we tackle it later (the ux proposal)
containerClassName={"shadow"} | ||
content={<Card body={content} />} | ||
> | ||
<span className={`code-details-summary-span ${className}`} onClick={this.toggleVisibility}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span className={`code-details-summary-span ${className}`} onClick={this.toggleVisibility}> | |
<span className={`code-details-summary-span${className}`} onClick={this.toggleVisibility}> |
return ( | ||
<Popover | ||
isOpen={open} | ||
position={["right", "top"]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed a prop from the lib so it decides best way to show it, works fine on mobile and desktop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some duplication remove
Co-Authored-By: montogeek <[email protected]>
Co-Authored-By: montogeek <[email protected]>
Co-Authored-By: montogeek <[email protected]>
testing this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This PR add support for custom Markdown in the Configuration page: https://webpack.js.org/configuration/, click the chevrons in the huge code example.
It is using mdx-loader to convert Markdown to React components, once in React, we can do pretty much anything with them.
That is just an example, some other ideas I have:
It is very important the accessible aspect, we have to make sure the entire doc is searchable using (Cmd|Ctrl)+F, it is a common interaction when looking for documentation.
You can see an demo of how it works here: https://gfycat.com/ArcticAdmiredAntipodesgreenparakeet