chore(rebuild): improve static html utilization #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change delays the dynamic part of app from mounting until the first page's content has loaded. This prevents the static content from being stripped from the DOM until dynamic bundle is there to replace it. Once we migrate to `remark-react`, the elements won't even be re-mounted as React's diffing algorithm will be used. All other pages are still loaded using dynamic `import()`s.
src/utilities/content-utils.js
Outdated
| * @return {array} - All markdown descendants of the given `tree` | ||
| */ | ||
| export const ExtractPages = tree => { | ||
| return FlattenContent(tree).filter(item => { |
There was a problem hiding this comment.
item => item.extension === '.md'
src/utilities/content-utils.js
Outdated
| * @return {array} - Immediate children of the given `tree` that are directories | ||
| */ | ||
| export const ExtractSections = tree => { | ||
| return tree.children.filter(item => ( |
There was a problem hiding this comment.
item => item.type === 'directory'
|
Looks good, would need to clone and check locally though, still trying to get some time to do that this weekend 👍 |
|
Just checked locally and it works like a charm, great work @skipjack. I think this is a big step towards the direction we are heading. Are we keeping the TODO up to date? |
jeremenichelli
approved these changes
May 6, 2018
montogeek
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to #2074 that addresses some core issues with how entry content is loaded. The changes contained here accomplish the following...
rendercall.Sitecomponent for use elsewhere in the site.