Skip to content

chore(rebuild): re-incorporate header links #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2018

Conversation

montogeek
Copy link
Member

Src code patched until
remarkjs/remark-autolink-headings#41 is merged, if
ever, we should probably use a fork.

@montogeek
Copy link
Member Author

It works by changing htmlAttributes to hProperties, basically remarkjs/remark-autolink-headings#41 changes.
@ben-eb @wooorm would accept a new PR with those changes?

@wooorm
Copy link

wooorm commented Apr 14, 2018

Ohh, seems Ben isn’t very active in remark anymore. Let me see and check in with him if he’s interested in moving it to @remarkjs

@montogeek
Copy link
Member Author

Thank you @wooorm !

@skipjack skipjack changed the title Add anchors links chore(rebuild): re-incorporate header links Apr 15, 2018
Src code patched until
remarkjs/remark-autolink-headings#41 is merged, if
ever, we should probably use a fork
@skipjack skipjack force-pushed the rebuild-add-anchors-links-to-headings branch from f98e22c to f61fdca Compare May 12, 2018 19:29
@skipjack
Copy link
Collaborator

@montogeek not seeing any links pop up in the h* elements... do I need to install the package from that fork in order for it to work?

@skipjack
Copy link
Collaborator

Nvm used @rigor789's fork, @rigor789/remark-autolink-headings, which works. Cleaning up the styling slightly and then pushing/merging and knocking another one down 🎉. Thanks for digging into this @montogeek.

@skipjack skipjack merged commit 633f94d into rebuild May 12, 2018
@skipjack skipjack deleted the rebuild-add-anchors-links-to-headings branch May 12, 2018 20:02
@montogeek
Copy link
Member Author

@skipjack Yep, I patched it locally applying same changes as that fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants