Skip to content

fix(config) Fix build time issue using defaut config #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 12, 2018

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Apr 11, 2018

Local build time ~540 seconds. Consequent builds for some reason take much less with a random difference varying from 82 seconds to 110 seconds per build using default yarn run build cmd

UPD:

  • local build time is unstable, subsequent builds take less time (down to 82 seconds from 540 seconds) for unknown reason, antwar needs more profiling, dropping this work to not waste time
  • this branch seems to build 20-25% faster than others due to node.js version bump
  • this branch renders contributors only clientside, will finally fix error event not firing for 50X/40X image responses from OC
  • redirects fixed, antwar.config.js redirects dont work at all in latest antwar version

@montogeek
Copy link
Member

@EugeneHlushko It is faster?

@EugeneHlushko
Copy link
Member Author

@montogeek locally it is stable at 92-106 seconds on my macbook pro 2015, i also noticed that after rebase not all of the redirects were in place and config's alignment went off. just fixed. seems node 8 speed up travis by 20% but not cut in half, trying to think of smth else meanwhile

@EugeneHlushko
Copy link
Member Author

@montogeek can you pull this one and try out locally?

@@ -101,12 +101,15 @@ module.exports = (env) => ({
}),
new RedirectWebpackPlugin({
redirects: {
'support': '/contribute/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where these new redirects come from?

antwar.config.js Outdated
@@ -16,77 +16,61 @@ module.exports = () => ({
layout: () => require('./src/components/Page/Page.jsx').default,
content: () => require.context('./loaders/page-loader!./src/content', false, /^\.\/.*\.md$/),
index: () => require('./src/components/Splash/Splash.jsx').default,
redirects: {
'support': '/contribute',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, completely miss them

@montogeek
Copy link
Member

Just ran yarn build:

real	16m16.693s
user	65m29.186s
sys	7m44.943s

@EugeneHlushko
Copy link
Member Author

EugeneHlushko commented Apr 12, 2018

Ok profiling it down shows that antwar diving into too many operations at once, limiting workers doesnt solve this. for example if you only build "/" and "concepts" pages it takes you 10 seconds, when you build all the pages the overhead is starting to show on my laptop and maximumWorkers doesnt solve this for me locally. Suggest to leave as is and focus on removing antwar (rebuild branch) @montogeek

I've updated the description and results of this spike, we can make separate branch for redirects and backers Clientside render if you want or we can test/review as is and continue here

@EugeneHlushko
Copy link
Member Author

I will rebase this after migrate section merge there are conflicts now

@EugeneHlushko
Copy link
Member Author

I suggest we merge this, anyone else you want to look at this @montogeek ?

@montogeek montogeek merged commit 0ebc4ac into master Apr 12, 2018
@montogeek
Copy link
Member

Thanks

@EugeneHlushko EugeneHlushko deleted the fix/buldtime-webpack branch April 12, 2018 12:42
montogeek added a commit that referenced this pull request Apr 13, 2018
montogeek added a commit that referenced this pull request Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants