-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(config) Fix build time issue using defaut config #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@EugeneHlushko It is faster? |
@montogeek locally it is stable at 92-106 seconds on my macbook pro 2015, i also noticed that after rebase not all of the redirects were in place and config's alignment went off. just fixed. seems node 8 speed up travis by 20% but not cut in half, trying to think of smth else meanwhile |
@montogeek can you pull this one and try out locally? |
@@ -101,12 +101,15 @@ module.exports = (env) => ({ | |||
}), | |||
new RedirectWebpackPlugin({ | |||
redirects: { | |||
'support': '/contribute/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where these new redirects come from?
antwar.config.js
Outdated
@@ -16,77 +16,61 @@ module.exports = () => ({ | |||
layout: () => require('./src/components/Page/Page.jsx').default, | |||
content: () => require.context('./loaders/page-loader!./src/content', false, /^\.\/.*\.md$/), | |||
index: () => require('./src/components/Splash/Splash.jsx').default, | |||
redirects: { | |||
'support': '/contribute', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, completely miss them
Just ran
|
Ok profiling it down shows that antwar diving into too many operations at once, limiting workers doesnt solve this. for example if you only build "/" and "concepts" pages it takes you 10 seconds, when you build all the pages the overhead is starting to show on my laptop and I've updated the description and results of this spike, we can make separate branch for redirects and backers Clientside render if you want or we can test/review as is and continue here |
I will rebase this after |
ed71ed3
to
4696820
Compare
I suggest we merge this, anyone else you want to look at this @montogeek ? |
Thanks |
Local build time ~540 seconds. Consequent builds for some reason take much less with a random difference varying from 82 seconds to 110 seconds per build using default
yarn run build
cmdUPD: