Evaluate all http redirects of outgoing links #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montogeek
reviewed
Apr 4, 2018
| @@ -25,7 +25,7 @@ const Footer = () => ( | |||
| <section className="footer__right"> | |||
| <Link className="footer__link" to="/glossary/">Glossary</Link> | |||
| <Link className="footer__link" to="/branding/">Branding</Link> | |||
| <Link className="footer__link" to="//gitter.im/webpack/webpack">Gitter</Link> | |||
| <Link className="footer__link" to="https://gitter.im/webpack/webpack">Gitter</Link> | |||
There was a problem hiding this comment.
I was going to commend about this https://www.paulirish.com/2010/the-protocol-relative-url/, but then realize is from 8 years ago and see that is now considered an antipattern, also realize how old I am 📟
There was a problem hiding this comment.
I very much know that feeling :D
montogeek
approved these changes
Apr 4, 2018
montogeek
approved these changes
Apr 4, 2018
|
Failing on profanity :/ |
skipjack
approved these changes
Apr 5, 2018
There was a problem hiding this comment.
LGTM, feel free to add kill to our .alexrc file per the comments in the stylelint-webpack-plugin PR:
https://github.com/webpack/webpack.js.org/blob/master/.alexrc
montogeek
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically replaced all external urls that had redirects pointing them to a different location.
Automated replacements based on output from hyperlink in #1582