Skip to content

Fixed missing line in diff and missing semicolons #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

RasmusFonseca
Copy link
Contributor

Minor fix of missing line in diff and semicolon

@RasmusFonseca
Copy link
Contributor Author

RasmusFonseca commented Mar 12, 2018

I did sign the CLA. Don't know why it's not showing up as accepted. Thanks for approving changes

@montogeek
Copy link
Member

montogeek commented Mar 13, 2018

@RasmusFonseca That is an automatic process. Can you push an empty commit? that may trigger the integration again.

Edit: It is signed :)

@montogeek montogeek merged commit 271ca48 into webpack:master Mar 13, 2018
Simek pushed a commit to Simek/webpack.js.org that referenced this pull request Mar 13, 2018
@RasmusFonseca RasmusFonseca deleted the patch-1 branch March 13, 2018 15:33
montogeek pushed a commit that referenced this pull request Dec 18, 2018
* docs(devServer): clarify devServer "open" option description

Added information that you can also use browser name in the config file.

* docs(devServer): add missing type to 'open' option

* docs(devServer): fix Travis CI

* docs(guides): fix sentence (#1887)

This removes a word that made a sentence not grammatically correct.

* docs (guides): Missing line in diff and missing semicolons (#1907)

* Update dev-server.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants