Skip to content

docs(all): add doctype for valid HTML in all documentation #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2018

Conversation

TheDutchCoder
Copy link
Collaborator

As pointed out in Issue #1866, this should be added for valid HTML.

As pointed out in Issue #1866, this should be added for valid HTML.
@montogeek
Copy link
Member

There are other placer where this happen, It is ok if I add them into this branch?

@TheDutchCoder
Copy link
Collaborator Author

@montogeek good point, I can skim through them as well, but feel free to do so of course.

@jeremenichelli
Copy link
Member

Can we organize this a little better? Because if not someone will look at this PR and the issues and think this wasn't done. It's important to make easy to track what has been changed for long tasks like this.

That said, are there more places where this is happening? Or we are sure these are all the doctypes that were missing?

@TheDutchCoder
Copy link
Collaborator Author

TheDutchCoder commented Mar 1, 2018

@jeremenichelli I've scanned all Guides and updated where required. Do you want to expand this to all sections of the website instead? I'm okay with that, it'll just widen the scope a bit more.

A quick search yields 9 places where HTML snippets are used in the src/directory, of which I've tackled 7 already, so we might as well expand it.

@TheDutchCoder TheDutchCoder changed the title Add doctype for valid HTML docs(guides): Add doctype for valid HTML Mar 1, 2018
@TheDutchCoder TheDutchCoder changed the title docs(guides): Add doctype for valid HTML docs(guides): add doctype for valid HTML Mar 1, 2018
@jeremenichelli
Copy link
Member

I would love to have each section as separate PRs, if that's already not possible, then list in the title of this PR all the sections you covered.

@montogeek
Copy link
Member

I only found another place missing, it seems there is not more places.

@TheDutchCoder TheDutchCoder changed the title docs(guides): add doctype for valid HTML docs(all): add doctype for valid HTML in all documentation Mar 1, 2018
@TheDutchCoder TheDutchCoder merged commit ea3ed2e into master Mar 1, 2018
@montogeek montogeek deleted the TheDutchCoder-patch-2 branch March 1, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants