-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Replace broken images in sponsor list #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you please share how it would look with the default webpack image? |
@montogeek |
Sorry, I mean the image you added in your changes. That screenshot is before of after your changes? |
That's great! It would look nicer showing the logo when the backer doesn't have an avatar:
|
@montogeek How long does it take to be reflected on website? :) |
This has to be reviewed, approved and merged. No idea if merging to master automatically deploys a new version. |
@montogeek |
That would be cool, so it would look like a wall of avatars instead of images and texts. Can you try it to see how it looks? |
Give me a minute :) |
It looks really nice! Thanks! |
I pushed again :) |
@Lutece I like the idea here, nice work. Doing a thorough review now and hopefully merging.
@montogeek it does automatically deploy although sometimes it takes a little while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Made a few minor tweaks for consistency and I'm going to quickly test locally but, assuming that all goes well, we'll get this merged soon.
Just tested, works fine. As soon as the build passes I'll get this merged. |
@skipjack Thanks! 👍 |
#1845 please look this issue
Resolves #1845