Code Splitting Guide Update #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sidebar.jsx) to link/mention explicit vendor splitting
rouzbeh84
force-pushed
the
hotfix/explicit-code-splitting
branch
from
3ddce46 to
d172a96
Compare
skipjack
approved these changes
Jul 9, 2017
|
@rouzbeh84 thanks and sorry for the delayed review... will merge as soon as the build passes (I made some minor edits). |
|
The link errors aren't related to these changes -- will see if they persist and fix in another PR if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating code-splitting to link/mention explicit vendor splitting per #1366