Fix Markdown Issue #1204
Merged
Fix Markdown Issue #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is allowed in GFM but not supported by marked. See this issue: markedjs/marked#595 Fixes #1187
bebraw
reviewed
May 11, 2017
utilities/markdown.js
Outdated
|
|
||
| // Fix escaped '|' characters | ||
| // See https://github.com/chjj/marked/issues/595 | ||
| let erroneous = row.map(item => item.endsWith('\\') ? item : null).filter(item => item !== null) |
There was a problem hiding this comment.
I might write this as
let erroneous = row.map(item => item.endsWith('\\') && item).filter(item => item)Same result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with escaped
|not being taken into account.This is allowed in GFM but not supported by marked. See this issue:
markedjs/marked#595
Fixes #1187
cc @Alex1990 @NejcZdovc