Skip to content

Improve lint:links - exclude support images/links #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2017

Conversation

simon04
Copy link
Collaborator

@simon04 simon04 commented May 4, 2017

@skipjack
Copy link
Collaborator

skipjack commented May 5, 2017

This is great, unfortunately we still have to figure out this FATAL ERROR: ... thing happening in the hyperlink package. I may test the suggestion here if that works as a temporary solution. @Munter maybe we should create an issue for this over at the hyperlink package to track a more stable fix?

@Munter
Copy link
Collaborator

Munter commented May 5, 2017

@skipjack Yeah, it's definitely hyperlinks fault

@skipjack
Copy link
Collaborator

skipjack commented May 5, 2017

@Munter thanks for being so responsive and helpful with this package... just created Munter/hyperlink#117 so we can track this.

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon04 if you tested your change on this PR locally and npm run lint:links worked ok I'm good with this being merged. We can resolve that hyperlink error on a separate PR.

@simon04
Copy link
Collaborator Author

simon04 commented May 5, 2017

Currently the check correctly fails due to one broken link. Maybe we should wait for webpack-contrib/less-loader#194 to be merged?

@skipjack
Copy link
Collaborator

skipjack commented May 6, 2017

@simon04 yea I'm good with that, I'll leave this to you then.

@simon04
Copy link
Collaborator Author

simon04 commented May 7, 2017

Since the other PR is merged, I'll merge this one as well. 😄

@simon04 simon04 merged commit 2a02816 into webpack:master May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants