Skip to content

Support Cleanup #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2017
Merged

Support Cleanup #1159

merged 3 commits into from
Apr 29, 2017

Conversation

skipjack
Copy link
Collaborator

Cleaning up the support component by...

  • updating the way sponsors are retrieved using the method mentioned in Randomize Open Collective sponsors and backers #411
  • abstracting the additional sponsors into a separate json sheet that follows the same model
  • concatenating the additional sponsors on to those fetched from open collective

This gives us full control over styling and allows us to...

I think this should resolve #411 as it has been inactive for a while and with this in place changing the display algorithm should be a piece of cake as we have more data to key off.

Thanks to @rafaelrinaldi for pinging opencollective to find out about the json feature!

skipjack added 3 commits April 27, 2017 01:07
@skipjack
chore(internal): add babel class properties transform and prop-types …
a93a55f 
…package
@skipjack
refactor(support): clean up support component and fetch actual json f…
d2e5324 
…rom opencollective

Fetching the actual JSON containing our supporters gives us more flexibility
to tackle issues like #411. It also give a model to follow for our, now extracted,
additional sponsors list (those not from open collective).
@skipjack
docs(sponsors): bump the sponsors displayed by another 10
6afd652
@skipjack skipjack requested a review from bebraw April 27, 2017 05:17
@skipjack skipjack mentioned this pull request Apr 28, 2017
Closed
@skipjack skipjack merged commit 127b445 into master Apr 29, 2017
@skipjack skipjack mentioned this pull request Apr 29, 2017
Closed
skipjack added a commit that referenced this pull request Apr 29, 2017
@skipjack
fix: patch backers and sponsors not being displayed
e6ee09e 
This was broken in #1159 as the `fetch` is never executed without it being
an interactive component. This is a quick fix for now, but after I discuss w
@bebraw, we should likely change this to run server-side somehow during
the build.
@skipjack
Copy link
Collaborator Author

Should've run a build-test ☹️ , this broke the support section as I think it needed to be an Interactive component. The fetch is never executed and therefore no sponsors are displayed. Testing a fix now -- if that doesn't work, I'll revert this pr.

@skipjack skipjack deleted the support-cleanup branch April 29, 2017 02:39
@skipjack skipjack mentioned this pull request Apr 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bebraw bebraw Awaiting requested review from bebraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Randomize Open Collective sponsors and backers
1 participant
@skipjack