DllPlugin & DllReferencePlugin docs #1121
Conversation
|
🚀 Great to see progress on this big black hole in the documentation of webpack 2 (#944). Over the weekend, I was also working on finally getting the Firstly, don't worry about the failing Travis build (this is due to an edit link of the new markdown file not yet existing). I see that this documentation is largely based on https://webpack.github.io/docs/list-of-plugins.html#dllplugin which seems a good start. Since the successful usage involves a correct configuration of
The question is how much time you'd be willing to invest for this documentation/PR? So whether you'd like to get this merged quickly or you're up to working and polishing this docs for some time. |
|
yes, it is based on the old documentation, with a fair bit of updating. thanks for the info about travis. where are the docs you made for the dll plugin? we could merge them :-) I had planned to add some examples to webpack/examples here https://github.com/webpack/webpack.js.org/pull/1121/files#diff-0dcb8884c3201edf1c374f1ea874abe3R76 I could port the two examples I have for my |
|
I stopped to write the docs right after I saw your PR. So there's not much to show. I summarised my ideas in my previous comment. It would be good to have one simple+minimal example (I like this one https://gist.github.com/Eoksni/83d1f1559e0ec00d0e89c33a6d763049) which shows the basic usage. Altered examples should show the other modes (scoped, mapped mode), and how Update this PR with some good examples and I'll review. |
🆕📘 added dll-example with a minimal multi-config setup (as suggested by @simon04 [here](webpack/webpack.js.org#1121 (comment)))
🙏 add simon04 to collaborators 🛁 clean commented example 🔗🌽 link to example pull request 🔗 add more named links to other parts of the dll plugin & dll reference plugin source code 🌊👣 add TemplatePaths type for `name` 🔬 more source code test links 📘 add examples section 📘⎁⎂ descriptions for the examples, explain what functionality they demonstrate
|
Aside from links to webpack examples added, I don't see any changes in the page structure (see #1121 (comment)) nor a change in the documentation of scoped mode, mapped mode and how to use |
simon04
changed the title
🆕📘 added dll-app-and-vendor example with a minimal multi-config setup (as suggested by @simon04 [here](webpack/webpack.js.org#1121 (comment)))
content/plugins/dll-plugin.md
Outdated
|
|
||
| The `DllPlugin` and `DllReferencePlugin` provide means to split bundles in a way that can drastically improve build time performance. | ||
|
|
||
| [DllPlugin](#DllPlugin) is used in a separate webpack config exclusively to create a dll-only-bundle. It creates a `manifest.json` file, which used by the [DllReferencePlugin](#DllReferencePlugin) to map dependencies. |
🏛️ update structure as suggested by @simon04 [here](webpack#1121 (comment)) ⚒⌨️ fix typo found by @smashercosmo webpack#1121 (review) 📘 added dll-example using `libraryTarget` + `sourceType` `"commonjs2"` to create a vendor bundle, and a dependency bundle, on nodejs. 📝 remove completed todos
|
@simon04 any thoughts? has been updated |
🆕📘 added dll-app-and-vendor example with a minimal multi-config setup (as suggested by @simon04 [here](webpack/webpack.js.org#1121 (comment)))
|
Since this PR references many not-yet-merged webpack examples, the Travis CI fails (HTTP 404). Feel free to drop those examples for now and submit another PR later. I won't review unless the CI succeeds. Also please make sure to read and follow https://webpack.js.org/writers-guide/#typesetting. |
|
@aretecode please re-open once you've rebased and dealt with the conflicts (or just open a new pr). |
Feedback appreciated