Skip to content

Union webpack.js.org repo and voting-app repo #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexander-akait opened this issue Mar 11, 2020 · 14 comments
Closed

Union webpack.js.org repo and voting-app repo #3614

alexander-akait opened this issue Mar 11, 2020 · 14 comments

Comments

@alexander-akait
Copy link
Member

Feature to document

Move voting-app repo https://github.com/webpack-contrib/voting-app inside that repo

Author(s)

Don't known

Additional information

Pros:

  • Easy to maintenance (all in one place)
  • Easy to update
  • Less repositories
  • When a feature was released it will easy to update status for voting app

[ ] I am willing to work on this issue and submit a pull request.

@alexander-akait alexander-akait changed the title Union webpack.js.org repo and voting-app Union webpack.js.org repo and voting-app repo Mar 11, 2020
@montogeek
Copy link
Member

inside that repo

Which repo?

@jeffin143
Copy link
Contributor

inside that repo

Which repo?

I guess he meant in this repo

@montogeek
Copy link
Member

If that is the case, why?
This repo should only host documentation, any external app, plugin, etc should be a dependency.

Initial discussion: #301
Initial implementation: #1717

@alexander-akait
Copy link
Member Author

@montogeek

Pros:

  • Easy to maintenance (all in one place)
  • Easy to update
  • Less repositories
  • When a feature was released it will easy to update status for voting app
  • Sync with partial implemented features

It is not high priority

@anshumanv
Copy link
Member

anshumanv commented Mar 13, 2020

I'll pick this up, in case we all agree with the change 👍

@EugeneHlushko
Copy link
Member

I dont think this is necessary, its already easy to update: #3617

@alexander-akait
Copy link
Member Author

alexander-akait commented Mar 17, 2020

@EugeneHlushko @montogeek we want to move all repos from webpack-contrib in long term (it is hard to maintance, a lot of people have access and potential do dangerous actions and etc), some of repos will be migrated to monorepo webpack/webpack-official, some of repos will be deprecated, some of them move out from official support, so we start it process, we need move voiting-app to here or maybe webpack/voting-app, I prefer first

@EugeneHlushko
Copy link
Member

we dont want any technical complexity in documentation repository, all modules that are abstractable should live in separate repositories. cc @skipjack

@alexander-akait
Copy link
Member Author

What about move it to webpack/voting-app?

@montogeek
Copy link
Member

montogeek commented Mar 17, 2020 via email

@alexander-akait
Copy link
Member Author

@anshumanv
Copy link
Member

I'll do it 👍

@EugeneHlushko
Copy link
Member

@anshumanv dont forget to do it via yarn on node 10, ty in advance!

@EugeneHlushko
Copy link
Member

its merged, ty all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants