-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Document webpack change: Add loader name to error message. Resolves #2878 #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @sokra i am not sure what we can update from this one, can you point out please? |
@ooflorent can you pls check this ? |
@EugeneHlushko Maybe update examples that show those errors? |
Yeah, @montogeek is right. This issue has been open because the error messages used in the documentation may require an update. |
Sorry for my late. Just let me try to update this tomorrow ☺ |
mc-zone
added a commit
to mc-zone/webpack.js.org
that referenced
this issue
Jun 26, 2018
montogeek
pushed a commit
that referenced
this issue
Dec 16, 2018
EugeneHlushko
added a commit
that referenced
this issue
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A pull request by @mc-zone was merged and maintainers requested a documentation change.
See pull request: webpack/webpack#6542
What kind of change does this PR introduce?
Feature.
Did you add tests for your changes?
Yes.
If relevant, link to documentation update:
N/A
Summary
Add loader name to Error message so that people can actually realize which loaders were emiting these errors clearly.
Demo:
webpack.config.js:
test-loader.js:
lib.test:
Current output:
After this PR:
Resolves #2878.
Does this PR introduce a breaking change?
Nope (I think).
Other information
Note: This feature also need some changes inwebpack/loader-runner
to handle errors fromthrow
andcallback(error)
(need add loader name toerror.from
). I will add it subsequently.Updated: Now using
loaderContext.loaderIndex
inNormalModule.js
for all to determine which loader the error is belong to .The text was updated successfully, but these errors were encountered: