Skip to content

Update the Concepts section with webpack v4 configuration #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeremenichelli opened this issue Mar 1, 2018 · 9 comments
Closed

Update the Concepts section with webpack v4 configuration #1870

jeremenichelli opened this issue Mar 1, 2018 · 9 comments

Comments

@jeremenichelli
Copy link
Member

jeremenichelli commented Mar 1, 2018

In the Concepts section we still have old config snippets and we also are not reflecting the fact that webopack is now zero config out of the box.

Some content might also need to be change so it's compatible with the new webpack default behavior.

@arjendeblok
Copy link

Also the home page of the web site still reflects that you need a config file. Should be changed too.

@jeremenichelli
Copy link
Member Author

Yeap. From above:

we also are not reflecting the fact that webopack is now zero config out of the box.

@EugeneHlushko
Copy link
Member

@jeremenichelli u on it or i can pick up both concepts configuration and homepage?

@jeremenichelli
Copy link
Member Author

jeremenichelli commented Mar 5, 2018

Go for it @EugeneHlushko! Assign the issues to yourself so we don't overlap (this one and the homepage and configuration).

Here's a list of things to needed actions on the config files or possible warnings:

  • update node.js to 8
  • install webpack-cli
  • upgrade loaders and pluginsConfig
  • add mode: "development"/"production" to config files
  • remove DefinePlugin process.env.NODE_ENV
  • remove NoEmitOnErrorsPlugin/NoErrorsPlugin
  • remove NewWatchingPlugin
  • remove ModuleConcatenationPlugin
  • remove NamedModulesPlugin
  • remove CommonsChunkPlugin
  • may add optimization.runtimeChunk
  • may add optimization.splitChunks.chunks: "all"
  • remove uglifyjs-webpack-plugin
  • may add optimization.minimizer for custom objects
  • module.loaders -> module.rulesCode
  • when import(cjs) access the default property

They are not mandatory, just a check list for you to look at when updating the config snippets. Have fun and thanks for collaborating!

@EugeneHlushko
Copy link
Member

@jeremenichelli there are not enough privileges i suppose to assign it on myself :(

@jeremenichelli
Copy link
Member Author

Whenever you want to grab some issue just be verbose in the comment thread and I will proceed to assign it to you 😊

@EugeneHlushko
Copy link
Member

thank you!

@EugeneHlushko
Copy link
Member

@montogeek @jeremenichelli this seems done now, can close i guess

@tylerlong
Copy link

According to the list, I guess NamedModulesPlugin is no longer required.

But it is still mentioned in the documentation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants