Skip to content

feat: camel modifier for v-bind #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 9, 2023
Merged

feat: camel modifier for v-bind #39

merged 5 commits into from
Dec 9, 2023

Conversation

LittleSound
Copy link
Member

close #37

<svg :view-box.camel="viewBox"></svg>
<!-- compiled as: -->
<svg viewBox="xxx"></svg>

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 88.2 kB 33.6 kB 30.3 kB
runtime-vapor.global.prod.js 17.2 kB 6.49 kB 5.97 kB
vue-vapor.global.prod.js 51.7 kB (+184 B) 17.3 kB (+61 B) 15.7 kB (+39 B)
vue.global.prod.js 145 kB 52.7 kB 47.1 kB

Usages

Name Size Gzip Brotli
createApp 48.8 kB 19.1 kB 17.5 kB
createSSRApp 52 kB 20.5 kB 18.7 kB
defineCustomElement 51.2 kB 19.9 kB 18.2 kB
vapor 17.1 kB 6.49 kB 5.97 kB
overall 62.2 kB 24 kB 21.9 kB

@LittleSound LittleSound force-pushed the feat/camel-modifier-for-vBind branch from 210d46b to e01d136 Compare December 8, 2023 10:44
@LittleSound LittleSound marked this pull request as ready for review December 8, 2023 10:45
sxzz
sxzz reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments for you.

@sxzz
Copy link
Member

sxzz commented Dec 8, 2023

I refactored unit tests via 5f76974. Could you please complete the unit tests I added to that commit?

@LittleSound LittleSound force-pushed the feat/camel-modifier-for-vBind branch from 04cc3f9 to 1a3d51c Compare December 9, 2023 02:25
@LittleSound
Copy link
Member Author

Sure, I've finished those tests.

@sxzz sxzz merged commit 26308c5 into vuejs:main Dec 9, 2023
@LittleSound LittleSound deleted the feat/camel-modifier-for-vBind branch December 9, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

camel modifier for v-bind
2 participants
@LittleSound @sxzz