Skip to content
This repository was archived by the owner on May 25, 2024. It is now read-only.

ガイドの Vite3 対応 #161

Merged
merged 10 commits into from
Aug 14, 2022
Merged

ガイドの Vite3 対応 #161

merged 10 commits into from
Aug 14, 2022

Conversation

k-miyake
Copy link
Collaborator

@k-miyake k-miyake commented Aug 10, 2022

closes #157, #158, #159

以下の対応を実施

  • Vite3 をベースとした create-vue が生成した css 関連のコードが、ハンズオンの例と衝突するためレンダリング章のコード変更前に削除するセクションを追加
  • 関連するサンプルコードを最新の create-vue が生成したコードに変更

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 10, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f25b3dc
Status: ✅  Deploy successful!
Preview URL: https://6c14c6eb.handson-vue3.pages.dev
Branch Preview URL: https://vite3-rendering.handson-vue3.pages.dev

View logs

@k-miyake k-miyake self-assigned this Aug 10, 2022
@k-miyake k-miyake marked this pull request as ready for review August 13, 2022 10:07
@k-miyake k-miyake requested a review from nalpan August 13, 2022 10:07
@k-miyake
Copy link
Collaborator Author

@nalpan レンダリング章で事前に不要なコードを削除する対応を行いました。

Copy link
Collaborator

@nalpan nalpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-miyake
ありがとうございます!良いと思います 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data を定義し、商品をレンダリングする #
2 participants