Skip to content

[Bugfix] Add revision to transformers.Auto*.from_pretrained processors #17948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xinli-centml
Copy link
Contributor

@xinli-centml xinli-centml commented May 10, 2025

Fix a rare care where specifying --revision does not change the behavior of huggingface processors (i.e. multi-modal video/image processors)

Seems like revision is being honored in all places other than vllm/transformers_utils/processor.py

~/projects/vllm$ grep -rin -l "\.from_pretrained(" ./vllm/
./vllm/model_executor/model_loader/neuronx_distributed.py
./vllm/model_executor/model_loader/neuron.py
./vllm/benchmarks/throughput.py
./vllm/transformers_utils/processor.py
./vllm/transformers_utils/config.py
./vllm/transformers_utils/tokenizer_base.py
./vllm/transformers_utils/tokenizer.py

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 11, 2025 03:04
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 11, 2025
@DarkLight1337 DarkLight1337 merged commit 90d0a74 into vllm-project:main May 11, 2025
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants