Skip to content

[BugFix] Correct max_model_len derivation from config.json for Mistral format #17937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

princepride
Copy link

@princepride princepride commented May 10, 2025

FIX #17747

@tjohnson31415

Thank you for your patience and suggestions.

  • I've reverted the code to its original version first before applying modifications.

  • I have removed all logic related to max_seq_len.

  • The subsequent logic (to fetch from standard Hugging Face config) will only be triggered if max_position_embeddings cannot be obtained from params.json.

  • I am referencing the configuration loaded from config.json as it's done for ConfigFormat.HF (i.e., using AutoConfig.from_pretrained).

  • Something went wrong, and I accidentally caused issues in the original branch, so I've opened a new PR to merge the code.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: 汪志鹏 <[email protected]>
@princepride
Copy link
Author

@DarkLight1337 Please excuse my being a newbie. I accidentally messed up the original branch, so I closed this pull request: #17777. Therefore, after modifying the code, I submitted it again. Could you please re-assign @tjohnson31415 as the reviewer for this bug fix? Thank you.

@DarkLight1337
Copy link
Member

cc @tjohnson31415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issues with max_model_len and config_format mistral
2 participants