Strict mypy

.tmuxp.yaml

@@ -12,6 +12,7 @@ windows:
   panes:
   - focus: true
   - pane
+  - make watch_mypy
   - make start
 - window_name: docs
   layout: main-horizontal

CHANGES

@@ -16,6 +16,12 @@ $ pip install --user --upgrade --pre libvcs
 ### What's new
 
 - New and improved logo
+- **Improved typings**
+
+  Now [`mypy --strict`] compliant ({issue}`390`)
+
+  [`mypy --strict`]: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-strict
+
 - **Parser**: Experimental VCS URL parsing added ({issue}`376`, {issue}`381`, {issue}`384`,
   {issue}`386`):
 

Makefile

@@ -52,3 +52,9 @@ watch_mypy:
 
 format_markdown:
 	prettier --parser=markdown -w *.md docs/*.md docs/**/*.md CHANGES
+
+monkeytype_create:
+	poetry run monkeytype run `poetry run which py.test`
+
+monkeytype_apply:
+	poetry run monkeytype list-modules | xargs -n1 -I{} sh -c 'poetry run monkeytype apply {}'

docs/conf.py

@@ -4,6 +4,7 @@
 import sys
 from os.path import dirname, relpath
 from pathlib import Path
+from typing import Union
 
 import libvcs
 
@@ -15,7 +16,7 @@
 sys.path.insert(0, str(doc_path / "_ext"))
 
 # package data
-about: dict = {}
+about: dict[str, str] = {}
 with open(project_root / "libvcs" / "__about__.py") as fp:
     exec(fp.read(), about)
 
@@ -58,8 +59,8 @@
 html_extra_path = ["manifest.json"]
 html_favicon = "_static/favicon.ico"
 html_theme = "furo"
-html_theme_path: list = []
-html_theme_options: dict = {
+html_theme_path: list[str] = []
+html_theme_options: dict[str, Union[str, list[dict[str, str]]]] = {
     "light_logo": "img/libvcs.svg",
     "dark_logo": "img/libvcs-dark.svg",
     "footer_icons": [
@@ -164,7 +165,9 @@
 }
 
 
-def linkcode_resolve(domain, info):  # NOQA: C901
+def linkcode_resolve(
+    domain: str, info: dict[str, str]
+) -> Union[None, str]:  # NOQA: C901
     """
     Determine the URL corresponding to Python object
 
@@ -197,7 +200,8 @@ def linkcode_resolve(domain, info):  # NOQA: C901
     except AttributeError:
         pass
     else:
-        obj = unwrap(obj)
+        if callable(obj):
+            obj = unwrap(obj)
 
     try:
         fn = inspect.getsourcefile(obj)

libvcs/_internal/dataclasses.py

@@ -72,7 +72,7 @@ class SkipDefaultFieldsReprMixin:
     ItemWithMixin(name=Test, unit_price=2.05)
     """
 
-    def __repr__(self):
+    def __repr__(self) -> str:
         """Omit default fields in object representation."""
         nodef_f_vals = (
             (f.name, attrgetter(f.name)(self))