Skip to content

Plastic branch display is broken #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PatHightree opened this issue Mar 6, 2025 · 9 comments
Closed

Plastic branch display is broken #185

PatHightree opened this issue Mar 6, 2025 · 9 comments
Labels
bug Something isn't working

Comments

@PatHightree
Copy link
Contributor

It seems that something in a recent build broke the display of the plastic branch for a project.
Git branches are still visible.

Image

@unitycoder unitycoder added the bug Something isn't working label Mar 6, 2025
@unitycoder
Copy link
Owner

ok ill have a look

could be related to that searchGitbranchRecursively feature that was added sometime ago..?
https://github.com/unitycoder/UnityLauncherPro/blob/master/UnityLauncherPro/GetProjects.cs#L168-L172

@unitycoder
Copy link
Owner

unitycoder commented Mar 6, 2025

downloaded some random plastic repo from github,
at least it does show this broken string:
image

can you also confirm that [x] git and [x] plastic are enabled in the settings? (if they have reset somehow)

@unitycoder
Copy link
Owner

or does your plastic.selector look like this
image

or this
image

unitycoder added a commit that referenced this issue Mar 6, 2025
@PatHightree
Copy link
Contributor Author

PatHightree commented Mar 6, 2025

My plastic.selector file looks like the second picture.
I verified that the git and plastic options are enabled in the settings.

@PatHightree
Copy link
Contributor Author

The problem isn't in the file structure, you're going one directory too deep.
Replacing line 188 in GetProjects.cs with this works
gitBranch = folderExists ? Tools.ReadPlasticBranchInfo(Directory.GetParent(projectPath).ToString()) : null;

@unitycoder
Copy link
Owner

unitycoder commented Mar 7, 2025

is the .plastic folder in this level normally?
image

or do you have Unity project one level lower than that?

.plastic
UnityProj/Assets/...

@PatHightree
Copy link
Contributor Author

There's many Unity projects in this repo, so :
.plastic
UnityProj1/Assets/...
UnityProj2/Assets/...
UnityProj3/Assets/...

I guess that's an odd configuration, but it worked great until recently.

@unitycoder
Copy link
Owner

that commit should fix it, ill make new build sometime soon!

need to have this enabled, to search from parent folders
image

@PatHightree
Copy link
Contributor Author

Yep, just tested it and it works great 👍
Thanks for the speedy fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants