Skip to content

fix(MCP): Added error status to traces in MCP server for tool calls #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025

Conversation

fali007
Copy link
Contributor

@fali007 fali007 commented May 9, 2025

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.
    This PR aims to add trace status for failed error calls. This helps in grouping error calls by nature of failures.
Screenshot 2025-05-09 at 1 02 14 PM

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 393f1cc in 2 minutes and 8 seconds. Click for details.
  • Reviewed 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-mcp/opentelemetry/instrumentation/mcp/instrumentation.py:253
  • Draft comment:
    Consider checking not only the existence of the 'isError' attribute but also its truthiness (e.g. if hasattr(request.result, 'isError') and request.result.isError:) to avoid falsely flagging non-error cases. Also, review if including the full serialized result in the error status may expose sensitive data.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_ZsBwRrBV1xwdPFCP

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

fali007 added 2 commits May 9, 2025 13:15
Signed-off-by: Felix George <[email protected]>
Signed-off-by: Felix George <[email protected]>
@nirga nirga merged commit cfbfbe9 into traceloop:main May 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants