Bug start directory #639
Bug start directory #639
Conversation
tmuxp/__about__.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| __title__ = 'tmuxp' | |||
| __package_name__ = 'tmuxp' | |||
| __version__ = '1.5.7post0' | |||
| __version__ = '1.5.7post1' | |||
There was a problem hiding this comment.
@joseph-flinn Can you make this 1.5.8?
| __version__ = '1.5.7post1' | |
| __version__ = '1.5.8' |
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
- Coverage 78.14% 77.95% -0.19%
==========================================
Files 6 6
Lines 828 830 +2
Branches 239 240 +1
==========================================
Hits 647 647
- Misses 121 122 +1
- Partials 60 61 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@joseph-flinn Make it 1.5.8 and update CHANGES - I will publish it now 😊
| session = self.server.new_session( | ||
| session_name=self.sconf['session_name'], | ||
| start_directory=self.sconf['start_directory'], | ||
| ) |
There was a problem hiding this comment.
It's late so I don't want to dredge this up, do we want/need a test for this?
There was a problem hiding this comment.
I'm happy merging without a test, I can write one later if we need it
There was a problem hiding this comment.
No worries. It would probably be a good idea to write a test just so we have it
|
@joseph-flinn v1.5.8 live |
start_directorywas not being passed through when creating a new session.Issue: #631