Skip to content

Remove cleanup references #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dustinmyers
Copy link
Contributor

@dustinmyers dustinmyers commented Aug 9, 2019

This pull request removes any instances of cleanup-after-each and afterEach(cleanup) in the react docs and examples. From issue #212

This commit removes any references to the cleanup-after-each
file in the react docs as it has been removed. Instructions
for skipping auto cleanup were also added to the docs.
This commit removes references to the afterEach function
in the react docs and examples
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this. Thanks for working on it! Just a few comments.

dustinmyers and others added 5 commits August 9, 2019 17:05
This commit add the cleanup section bac into the api docs
for those that may need to do manual cleanups.
The api docs now show a relevant example using the AVA
testing framework.
…sting-library-docs into remove-cleanup-references
This commit removes the paragraph at the end of the
cleanup section in the api docs that talks about
configuring the cleanup globally
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 0f56996 into testing-library:master Aug 9, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @dustinmyers for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @dustinmyers! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants