wip: Improve CSS syntax highlighting #1367
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1365
Fixes #1340
Fixes #1250
This PR is intended to improve syntax highlighting for CSS. Currently things like
@pluginare not always handled right, declarations inside@thememay be incorrectly tokenized — or even not at all, etc…This is very much a work in progress. I'd like find a way to add proper nesting support by injecting blocks into existing patterns of the
source.cssgrammar but that may not be possible. We'll likely need to copy the CSS grammar from VSCode and modify it.