Fix types #8
Merged
Fix types #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
🤞 phase/open
wooorm
approved these changes
Feb 7, 2023
This comment has been minimized.
This comment has been minimized.
|
Thank you, released in 2.2.4! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Added a type import that was causing problems with using this library: namely mdast nodes didn't inherit from Mdast.Parent but from a non typed version of it Parent=any. This was causing type checks to fail on properties like node.data.
I apologize in advance if i was not understanding the issue fully before making any changes, as this is my first contribution, but this small fix is what i found to be the problem, cheers and have a good day.