[3.0] [ClassLoader] removed deprecated UniversalClassLoader and DebugClassLoader classes. #13203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hhamon
commented
Jan 2, 2015
hhamon
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
hhamon
force-pushed
the
classloader-remove-deprecated-structures
branch
2 times, most recently
from
e087303 to
5921cd9
Compare
hhamon
changed the title
| @@ -60,7 +60,7 @@ | |||
| * | |||
| * @api | |||
| */ | |||
| class ApcUniversalClassLoader extends UniversalClassLoader | |||
| class ApcUniversalClassLoader extends ClassLoader | |||
There was a problem hiding this comment.
This is wrong. The ApcUniversalClassLoader should be removed entirely (we already have the ApcClassLoader as a replacement, which is way better since it uses composition rather than inheritance).
There was a problem hiding this comment.
Thanks for the notice! I will update the PR. The ApcUniversalClassLoader is not tagged as @deprecated anywhere. That's why I thought we had to keep it. I will update my deprecation notices PR as well to mark the class deprecated.
There was a problem hiding this comment.
Current PR has been updated with your suggestions.
hhamon
force-pushed
the
classloader-remove-deprecated-structures
branch
from
5921cd9 to
fda582f
Compare
| @@ -16,10 +16,10 @@ | |||
| * | |||
| * @author Fabien Potencier <[email protected]> | |||
| */ | |||
| class DebugUniversalClassLoader extends UniversalClassLoader | |||
| class DebugUniversalClassLoader extends ClassLoader | |||
There was a problem hiding this comment.
The DebugUniversalClassLoader should also be removed entirely in favor of the DebugClassLoader (special flavors of the UniversalClassLoader are actually meant to be deprecated at the same time than the UniversalClassLoader itself)
hhamon
force-pushed
the
classloader-remove-deprecated-structures
branch
4 times, most recently
from
38e5f2b to
9c5b177
Compare
|
@hhamon Can you rebase on current master? |
hhamon
force-pushed
the
classloader-remove-deprecated-structures
branch
from
9c5b177 to
a6cfbe5
Compare
|
@fabpot rebased! ;) |
| 2.7.0 | ||
| ----- | ||
|
|
||
| * The UniversalClassLoader class has been deprecated in favor of ClassLoader class |
There was a problem hiding this comment.
This should be removed as the class was deprecated in 2.4.
hhamon
force-pushed
the
classloader-remove-deprecated-structures
branch
from
a6cfbe5 to
1d7cbdd
Compare
|
Thank you @hhamon. |
fabpot
added a commit
that referenced
this pull request
Jan 16, 2015
…oader and DebugClassLoader classes. (hhamon) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0] [ClassLoader] removed deprecated UniversalClassLoader and DebugClassLoader classes. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 1d7cbdd [ClassLoader] removed deprecated UniversalClassLoader and DebugClassLoader classes.
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
Jan 16, 2015
The `DebugClassLoader` has been moved to the Debug component with Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
Jan 31, 2015
The `DebugClassLoader` has been moved to the Debug component with Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
Jan 31, 2015
The `DebugClassLoader` has been moved to the Debug component with Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
May 24, 2015
The `DebugClassLoader` has been moved to the Debug component with Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
May 24, 2015
The `DebugClassLoader` has been moved to the Debug component with Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
May 24, 2015
The `DebugClassLoader` has been moved to the Debug component with Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 9, 2015
The `DebugClassLoader` has been moved to the Debug component with Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203).
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 9, 2015
This PR was submitted for the 2.5 branch but it was merged into the 2.6 branch instead (closes #4947). Discussion ---------- [Components][ClassLoader] remove DebugClassLoader | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | 2.5 | Fixed tickets | The `DebugClassLoader` has been moved to the Debug component with Symfony 2.4 and will be removed in 3.0 (see symfony/symfony#13203). This replaced #4855 by removing the `DebugClassLoader` docs from ClassLoader component in the 2.5 version, but keeping a redirect to the description in the Debug component. The redirection map entry should then be removed once the changes got merged up into the `master` branch. Commits ------- 73e9833 [Components][ClassLoader] remove DebugClassLoader
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.