Fix factory-service new syntax #9701
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwage
approved these changes
Apr 28, 2018
javiereguiluz
approved these changes
Apr 29, 2018
There was a problem hiding this comment.
@lex111 good catch! And you are right about Symfony versions too. This applies to 2.7 too (https://github.com/symfony/dependency-injection/blob/ae8effd3cdafad8e2652fccc5e5bcf991dbd6af1/Definition.php#L63-L65) so we'll merge this on 2.7 branch (you don't need to rebase it, we'll do that for you). Thanks!
javiereguiluz
added a commit
that referenced
this pull request
May 2, 2018
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9701). Discussion ---------- Fix factory-service new syntax As I understand, this applies to all versions, not just 4.0. At least, the factory does not work for me, if I use only one `:` https://github.com/symfony/dependency-injection/blob/e237279af4735c1566a62853c65de12b3266f0ef/Definition.php#L106-L108 Commits ------- 475cdc7 Fix factory-service new syntax
This was referenced May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand, this applies to all versions, not just 4.0. At least, the factory does not work for me, if I use only one
:https://github.com/symfony/dependency-injection/blob/e237279af4735c1566a62853c65de12b3266f0ef/Definition.php#L106-L108