Added hints to spool config section #5848
Conversation
The former explanation suggests that a single file is used for spooling, which is not the case of course. But I ran into that problem and since Symfony falls back to memory if the dir is not writable (as it seems) with no error message, this addition might help some people to get spools running.
| @@ -55,10 +55,15 @@ swiftmailer with the memory option, use the following configuration: | |||
| 'spool' => array('type' => 'memory') | |||
| )); | |||
|
|
|||
| Spool Using a File | |||
| Spool Using Files | |||
There was a problem hiding this comment.
We should add label for the old headline before:
.. _spool-using-a-file:There was a problem hiding this comment.
I'm sorry, I don't get it. The Table of contents is updated automatically. Why should we do this?
There was a problem hiding this comment.
With a little icon next to each headline on symfony.com, we allow the readers to link to specific sections on a page. This is done by using the automatically created anchor (slugified headline text).
If we change the headline, the automatically generated anchor changes as well (in this case it was spool-using-a-file and now is spool-using-files). This means that all links to the specific section are broken. If we add the old anchor as well, both anchors will link to this section. It's like backwards compatibility for documentations.
|
@martinczerwi 👍 your pull request looks like a very nice (and needed) addition to the spool docs. Thank you! A question to doc maintainers: can we label this PR as "finished"? Thanks. |
|
👍 looks great Sorry I did not notice earlier that you made the required change @martinczerwi, but we do not get any notifications when new commits are pushed to a pull request. Just leave a comment when you make some changes to a PR and we will receive notifications. :) |
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5848). Discussion ---------- Added hints to spool config section | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - The former explanation suggests that a single file is used for spooling, which is not the case of course. But I ran into that problem and since Symfony falls back to memory if the dir is not writable (as it seems) with no error message, this addition might help some people to get spools running. Commits ------- a460028 Added hints to spool config section
|
Thank you for these nice improvements and sorry for the delay @martinczerwi. I have merged your changes into the |
The former explanation suggests that a single file is used for spooling, which is not the case of course. But I ran into that problem and since Symfony falls back to memory if the dir is not writable (as it seems) with no error message, this addition might help some people to get spools running.