-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added mentions to some popular (and useful) Symfony bundles #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -250,4 +250,10 @@ file: | |
), | ||
)); | ||
|
||
.. tip:: | ||
|
||
Instead of using Assetic and Jpegoptim, you can also compress and manipulate | ||
images before serving them using the `LiipImagineBundle`_ community bundle. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Imagine will not perform the optimization for you. and this article is precisely about Assetic, so the note is misleading. btw, compressing images dynamically instead of compressing them during the asset dumping is a bad idea for performance (the LiipImagineBundle use case is for images uploaded by users which then need to be manipulated, not really for your assets, while Assetic is about your assets) |
||
|
||
.. _`Jpegoptim`: http://www.kokkonen.net/tjko/projects.html | ||
.. _`LiipImagineBundle`: http://knpbundles.com/liip/LiipImagineBundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this bundle is abotu OAuth authentication. this is not specific to Twitter, Facebook or Google only. The wording should be improved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. I think that mentioning Google, Facebook and Twitter explicitly is the best way to explain the purpose of this bundle.