Removing a section about Roles that I think has no real use-case #5184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added 4 years ago at sha: 5a2824b, and it's original purpose was to talk about Roles as domain objects. If this has a real-use case, then we should clarify what it is, and move it to its own cookbook. This is a details that beginners are trying to deal with, unnecessarily.
|
👍 I fully agree with you. |
|
👍 This will also (in a way) fix #5183. |
|
👍 |
|
👍 |
|
Thanks guys - sounds like a home run :) |
weaverryan
added a commit
that referenced
this pull request
Apr 17, 2015
…se-case (weaverryan) This PR was merged into the 2.3 branch. Discussion ---------- Removing a section about Roles that I think has no real use-case Hi guys! | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a This came up after a conversation with someone on Twitter that got hung up on this section (they were also new to Doctrine, so the ManyToMany relationship was a bit challenging). But it occurred to me that this section is totally unnecessary for beginners, and maybe totally unnecessary for *everyone*. Is there a real-use case for this? It was added 4 years ago at sha: 5a2824b, and it's original purpose was to talk about Roles as domain objects. If this has a real-use case, then we should clarify what it is, and move it to its own cookbook. This is a details that beginners are trying to deal with, unnecessarily. Thanks! Commits ------- 6c9ce9c Removing a section about Roles that I think has no real use-case
weaverryan
added a commit
that referenced
this pull request
Oct 15, 2015
…yan) This PR was merged into the 2.3 branch. Discussion ---------- [WIP] Reworking most of the registration form: Hi guys! | Q | A | ------------- | --- | Doc fix? | yes (because it's got bad recommendations) | New docs? | no | Applies to | 2.3+ | Fixed tickets | -- After trading emails with a user, I realized that we have this very out-dated registration form chapter. Wow :). A summary of the changes: 1) Showing the embedded Registration model is way too hard and unnecessary 2) Stopped persisted plainPassword (why did we do this?) 3) Used AppBundle approach 4) Annotation routing 5) various other small things This is still a WIP only because I have 2 sections at the bottom I still want to add. Review for what is here now is appreciated. Honestly, I was a little surprised that entries like this can "hide" in the docs and get so out of date. It's a testament to how big our docs are, but it's a bit of a problem (this is similar to #5184 that had something totally irrelevant in an important doc). Things to update during merge: - password encoder - remove getName() in 2.8 - setDefaultOptions Thanks! Commits ------- a8275a3 Fixing build error 8b7fc79 Tweaks thanks to everyone! 1c1b92a [WIP] Reworking most of the registration form:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This came up after a conversation with someone on Twitter that got hung up on this section (they were also new to Doctrine, so the ManyToMany relationship was a bit challenging). But it occurred to me that this section is totally unnecessary for beginners, and maybe totally unnecessary for everyone. Is there a real-use case for this?
It was added 4 years ago at sha: 5a2824b, and it's original purpose was to talk
about Roles as domain objects. If this has a real-use case, then we should clarify
what it is, and move it to its own cookbook. This is a details that beginners are
trying to deal with, unnecessarily.
Thanks!