Skip to content

Improved the explanation about the "secret" configuration parameter #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets -

@dupuchba
Copy link

👍

and for creating signed URIs when using :ref:`ESI (Edge Side Includes) <edge-side-includes>` .

This option becomes the service container parameter named ``kernel.secret``,
which you can use whenever the application needs a immutable random string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an immutable

which you can use whenever the application needs an immutable random string
to add more entropy.

As with any other security-related parameter, is a good practice to change this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"[...]parameter, it is a [...]"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

@ricardclau
Copy link
Contributor

👍 to this. The sentence delete the HTTP Cache related cache sounds a bit weird but I cannot think of a better way to say it in a generic way.

@javiereguiluz
Copy link
Member Author

@ricardclau you are right about that sentence. It sounds awful. I've just reworded it. Thanks Ricard.

@weaverryan
Copy link
Member

Wonderful explanation! Thanks Javier!

@weaverryan weaverryan merged commit ac3a74d into symfony:2.3 Apr 27, 2015
weaverryan added a commit that referenced this pull request Apr 27, 2015
…on parameter (javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Improved the explanation about the "secret" configuration parameter

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | -

Commits
-------

ac3a74d Minor rewording
db5db0f Fixed a minor grammar issue
74841e6 Minor rewording
4bbd84a Fixed some typos
b13250d Improved the explanation about the "secret" configuration parameter
@javiereguiluz javiereguiluz deleted the improve_secret_option_explanation branch January 3, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants