Reviewed Cache cookbook articles #5096
Conversation
|
|
||
| This port depends on your setup. Lets say that external connections come in | ||
| This port depends on your setup. Let's say that external connections come in |
There was a problem hiding this comment.
I've reworded it a bit, but I don't know if it's enough.
|
Sounds good to me. Maybe @dbu can also take a look at these changes. |
| connections, there is another proxy (as Varnish does not do HTTPS itself) on the | ||
| default HTTPS port 443 that handles the SSL termination and forwards the requests | ||
| as HTTP requests to Varnish with a ``X-Forwarded-Proto`` header. In this case, | ||
| add the following to your Varnish configuration: |
There was a problem hiding this comment.
maybe we should first say that the terminator should set this header, and varnish will forward the headers to the application. that would be the right place for this. and only if the proxy in front of varnish can not be made to set the headers, one can hack them into varnish.
There was a problem hiding this comment.
@dbu You're referring specifically to the X-Forwarded-Port, correct? In other words, the proxy that is terminating the SSL should set the X-Forwarded-Proto AND the X-Forwarded-Port headers. But in case X-Forwarded-Port is not set by that layer for some reason, you can add the below hack to Varnish so that it adds it.
Am I correct? Thx :)
There was a problem hiding this comment.
@weaverryan yep, exactly, that is what i mean.
|
Looks nice to me! I have one question out still to @dbu, and based on his response, I may make another small PR to tweak things. Thanks Javier! |
This PR was merged into the 2.3 branch. Discussion ---------- Reviewed Cache cookbook articles | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Although I admit that I don't use Varnish, I think the current documentation is a bit confusing. I haven't added or deleted any content, but I reordered things to make them easier to read and understand. Commits ------- 80387cf Minor rewording f11fe4f Reviewed Cache cookbook articles
Although I admit that I don't use Varnish, I think the current documentation is a bit confusing. I haven't added or deleted any content, but I reordered things to make them easier to read and understand.