Trim default is false in password field #5061
Conversation
The Password field define the inherited trim option to false.
| .. include:: /reference/forms/types/options/trim.rst.inc | ||
| trim | ||
| ~~~~ | ||
| **type**: ``Boolean`` **default**: ``false`` |
There was a problem hiding this comment.
Can you please add a blank line before and after this line and change Boolean to bool?
There was a problem hiding this comment.
I added the blank lines but I prefer to let Boolean rather than bool for the moment as all the others references in the documentation use Boolean.
|
Thank you for the pull request, @raziel057. This is a really good catch! I just left you two little comments. After fixing them, the pull request is ready to be merged. |
| **type**: ``Boolean`` **default**: ``false`` | ||
|
|
||
| If true, the whitespace of the submitted string value will be stripped | ||
| via the ``trim()`` function when the data is bound. This guarantees that |
There was a problem hiding this comment.
can you maybe use the :phpfunction:trim`` role? This will automatically generate a link to PHP.net.
|
Sorry @raziel057, I forgot to review this PR some weeks ago. I've now added one little comment, after it, I'll flag it as finished and someone can merge it :) |
|
@wouterj I changed the |
|
Perfect! 👍 |
|
Now GitHub is stable, I can finally merge this one. Thanks Thomas for your quick action and great fix! |
The Password field define the inherited trim option to false.