-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Updated the generic Deployment article #5003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
javiereguiluz
commented
Feb 17, 2015
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | 2.3+ |
Fixed tickets | - |
This entry doesn't try to explain everything, but rather offers the most | ||
common requirements and ideas for deployment. | ||
Deploying can be a complex and varied task depending on the setup and | ||
requirements of your application. This article is not a step-by-step guide, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[...] and the requirements [...]
@xabbuh thanks for your review. Everything is fixed now. |
#. Upload your modified code to the live server; | ||
#. Update your vendor dependencies (typically done via Composer, and may | ||
#. Upload your code to the production server; | ||
#. Install/update your vendor dependencies (typically done via Composer, and may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should remove the serial comma before "and"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
during a deploy, I would only advertise to install deps.
Thanks, lots of good fixes in here! Please note that I've commented as if you added all these things. I know you didn't, but I'm too used to that way of reviewing. Take it as opinions on the content and not your diff :) |
`sf2debpkg`_ | ||
Helps you build a native Debian package for your Symfony project. | ||
|
||
`Magallanes`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we please add fabric? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my favorite thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion: Fabric is indeed very popular, so I've added a reference to it in 9e01941
No worries Wouter. I love your reviews! I've fixed everything you said and I've removed the reference to the IRC channel. |
Nice improvements here :). Thanks as always Javier! |
This PR was merged into the 2.3 branch. Discussion ---------- Updated the generic Deployment article | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - Commits ------- 9e01941 Minor fixes and added Fabric tool 58526f7 Fixed grammar issues 576d505 Improved the text of the links 9488a85 Updated the contents of the generic Deployment article