Skip to content

[Cookbook][Form] update form_customization.rst #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Cookbook][Form] update form_customization.rst #4797

wants to merge 1 commit into from

Conversation

gilles-g
Copy link
Contributor

@gilles-g gilles-g commented Jan 8, 2015

Q A
Doc fix? no
New docs? yes
Applies to 2.3+

@wouterj wouterj mentioned this pull request May 4, 2015
Closed
@javiereguiluz
Copy link
Member

@xabbuh @wouterj any comment on this pull request? Thanks.

xabbuh
xabbuh reviewed Jun 23, 2015
View reviewed changes
cookbook/form/form_customization.rst
@@ -734,6 +734,24 @@ You can also override the markup for an entire field row using the same method:
<?php echo $view['form']->widget($form) ?>
</div>

How to Customize a collection Field
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Collection" should be uppercased according to our style guide.

@xabbuh
Copy link
Member

xabbuh commented Jun 23, 2015

I think we should just handle this in #4629 as suggested by @wouterj in #4629 (comment). I will take care of it.

@wouterj wouterj mentioned this pull request Aug 20, 2015
Merged
@wouterj
Copy link
Member

wouterj commented Aug 20, 2015

Hi @Spike31!

I've taken your and @xabbuh's PRs and combined them into #5643. Thank you for documenting this feature!

@wouterj wouterj closed this Aug 20, 2015
@gilles-g gilles-g deleted the form_theming_collection branch September 7, 2015 07:15
xabbuh added a commit that referenced this pull request Oct 3, 2015
@xabbuh
minor #5643 Document how to customize the prototype (daFish, WouterJ)
504a8f9 
This PR was merged into the 2.3 branch.

Discussion
----------

Document how to customize the prototype

Finishes #4629 and #4797

| Q | A
| --- | ---
| Doc fix? | no
| New docs? | yes
| Applies to | all
| Fixed tickets | -

Commits
-------

ce8110c Improve docs on customizing prototype rendering
051a23f document how to render custom collection prototypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilles-g @javiereguiluz @xabbuh @wouterj